"GPL (v2 or later)", "Unknown or generated". Note: Checking patched sources after %prep for licenses.
Gimp dds plugin could not open image license#
: License field in the package spec file matches the actual license. : Package complies to the Packaging Guidelines : Package is not known to require ExcludeArch. : Package uses nothing in %doc for runtime. : Package requires other packages for directories it uses. : Development files must be in a -devel package : Package contains desktop file if it is a GUI application.
Gimp dds plugin could not open image code#
: Sources contain only permissible code or content. : Package contains no bundled libraries without FPC exception. : %build honors applicable compiler flags or justifies otherwise. : Package is licensed with an open-source compatible license and meets : Rpath absent or only used for internal libs.
: Package does not contain any libtool archives (.la) : Package contains no static executables. : Package does not contain kernel modules. = Pass, = Fail, = Not applicable, = Not evaluated Generated by fedora-review 0.2.0 (53cc903) last change: Ĭommand line :/usr/bin/fedora-review -b 821404 : MUST Each %files section contains %defattr if rpm = 2.4 : MUST Sources contain only permissible code or content. Note: Clean would be needed if support for EPEL is required : MUST Package has no %clean section with rm -rf % (or : MUST Package contains no bundled libraries. Note: Unless packager wants to package for EPEL5 this is fine That are listed in the exceptions section of Packaging Guidelines. : MUST All build dependencies are listed in BuildRequires, except for any : MUST %build honors applicable compiler flags or justifies otherwise. Least one supported primary architecture. : MUST Package successfully compiles and builds into binary rpms on at Other legal requirements as defined in the legal section of Packaging : MUST Package is licensed with an open-source compatible license and meets : EXTRA Spec file according to URL is the same as in SRPM. Note: There are rpmlint messages (see attachment). : EXTRA Rpmlint is run on all installed packages. : MUST Rpath absent or only used for internal libs.
: MUST Package contains no static executables. : MUST Package does not contain kernel modules.
: MUST Package does not contain any libtool archives (.la) : MUST Header files in -devel subpackage, if present. I believe it is ok that your source line does not use the name macro, since the package probably should have the -plugin suffix. Also you might as well declare version 2.1.0 as the initial release and remove the other entries.Ĥ) Run fedora-review when completed so you can correct the minor issues before getting an official review. Then either import upstream's changes or link to upstream note with a patch.ģ) Changelog should match the RPM version. 1) Remove unneeded defattr in files section.Ģ) Need to notify upstream about the FSF address being incorrect ( ) in the headers and source files, preferably with a patch.
0 kommentar(er)
